It is currently Sat Dec 16, 2017 1:24 am


All times are UTC




Post new topic Reply to topic  [ 26 posts ]  Go to page Previous  1, 2, 3
Author Message
 Post subject: Re: [PATCH] Fix for packet looping on platforms with Gt96k F
PostPosted: Mon Mar 03, 2014 9:04 am 
Offline

Joined: Sat Feb 22, 2014 9:47 pm
Posts: 11
Hi everyone,

I am very glad the patch seems to be working. Regarding the extra line in the ping output - I do not think it is indicative of any issue. I have had the same symptom in my dynamips topology - I believe it's the IOS simply paginating the output in some funny way :) In any case, packets do not seem to get lost; all pings are responded to correctly. If anyone is willing to do a test - please do a packet capture on all links in the topology and check whether all packets are seen, and no packet looping/multiplication occurs.

Best regards,
Peter




Top
 Profile  
 
 Post subject: Re: [PATCH] Fix for packet looping on platforms with Gt96k F
PostPosted: Mon Mar 03, 2014 10:25 am 
Offline

Joined: Sun Sep 16, 2012 9:55 pm
Posts: 541
Location: England
Thankyou for the work paluchpeter! It's good to Dynamips is getting some good attention and being moved forward!

I expect flaviojs will pick up your patches from here... but also free to fork the Github repository (https://github.com/GNS3/dynamips) apply your patches and send in pull requests to have you r code merged in to the main source.

Many thanks! Keep up the good work ;)

_________________
Daniel
Forum Moderator & Debian Package Maintainer for GNS3, Dynamips & VPCS.
Standalone DEB Packages are available from http://gns3.serverb.co.uk - To be updated!


Top
 Profile  
 
 Post subject: Re: [PATCH] Fix for packet looping on platforms with Gt96k F
PostPosted: Mon Mar 03, 2014 4:24 pm 
Offline

Joined: Wed Feb 16, 2011 5:07 pm
Posts: 114
In the meantime, waiting for the official release, you can download 0.2.11 + multicast patches for windows, from this link:

https://t.co/8cdrcpREym

nothing else was modified, i only patches the official 0.2.11 with the 2 patches discussed here and built...

have fun :)


Top
 Profile  
 
 Post subject: Re: [PATCH] Fix for packet looping on platforms with Gt96k F
PostPosted: Tue Mar 04, 2014 1:51 pm 
Offline

Joined: Sat Feb 22, 2014 9:47 pm
Posts: 11
Hi,

Thanks everyone for testing the patches and for your kind words.

Best regards,
Peter


Top
 Profile  
 
 Post subject: Re: [PATCH] Fix for packet looping on platforms with Gt96k F
PostPosted: Wed Mar 05, 2014 10:21 pm 
Offline

Joined: Wed May 22, 2013 7:48 am
Posts: 93
Location: Portugal
Hohoo, indeed it works! With this patch all multicast issues (c2691, c3725 and c3745) should be fixed.

I get busy with stuff and when I come back I get another great present from Peter, you're awesome! ^^
This is for you: http://www.playfair.com/standingO/standingO.htm

_________________
Dynamips maintainer and sporadic developer
https://github.com/GNS3/dynamips


Top
 Profile  
 
 Post subject: Re: [PATCH] Fix for packet looping on platforms with Gt96k F
PostPosted: Thu Mar 06, 2014 12:39 am 
Offline

Joined: Wed May 22, 2013 7:48 am
Posts: 93
Location: Portugal
Patch applied in this commit: 79838a4.
Will be a part of dynamips 0.2.12.

Fixes issue #29 - packet loss with multicast traffic

-----

Regarding the 4-byte shift:

gt96k has a lot of settings related to endianness and swapping bytes/half-words/words.
dynamips ignores them and assumes the particular combination being used in cisco routers... =~~

If you compare struct sdma_desc with "Figure 52: SDMA Descriptor Format" of DSA-655899.pdf you'll notice that the words (32-bit) of every long-word (64-bit) are swapped.
That +4 is the offset of struct sdma_desc.cmd_stat.
It appears the original author noticed that function was missing the offset from 0.2.6-RC2 to 0.2.6-RC3 but forgot to update the one inside the loop.



_________________
Dynamips maintainer and sporadic developer
https://github.com/GNS3/dynamips


Top
 Profile  
 
Display posts from previous:  Sort by  
Post new topic Reply to topic  [ 26 posts ]  Go to page Previous  1, 2, 3

All times are UTC


Who is online

Users browsing this forum: No registered users and 0 guests


You cannot post new topics in this forum
You cannot reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum
You cannot post attachments in this forum

Search for:
Jump to:  
Powered by phpBB® Forum Software © phpBB Group

phpBB SEO