It is currently Sun Aug 25, 2019 7:03 am


All times are UTC




Post new topic Reply to topic  [ 56 posts ]  Go to page Previous  1, 2, 3, 4, 5, 6  Next
Author Message
 Post subject: Re: Patch for Qemu 0.14.X
PostPosted: Wed May 11, 2011 3:28 pm 
Offline

Joined: Fri Mar 11, 2011 7:39 pm
Posts: 603
Location: Israel
Please don't commit it to SUSE RPM of Qemu, before you speak with upstream Qemu guys. We must know what problems might arise. After they accept upstream (or at least evaluate), back-porting is an option.




Top
 Profile  
 
 Post subject: Re: Patch for Qemu 0.14.0
PostPosted: Thu May 12, 2011 5:13 am 
Offline

Joined: Wed Feb 16, 2011 5:07 pm
Posts: 114
of course... that's why i created a repository just for testing..


Top
 Profile  
 
 Post subject: Re: Patch for Qemu 0.14.0
PostPosted: Thu May 12, 2011 4:13 pm 
Offline

Joined: Fri Mar 11, 2011 7:39 pm
Posts: 603
Location: Israel
Your Qemu 0.14.1 package works ! (tested with UDP tunnel)

You should try to submit this patch upstream, *but* it's syntax could be improved.

Current Qemu has two modes: (first is TCP unicast, second is UDP multicast)
-net socket[,vlan=n][,name=name][,fd=h] [,listen=[host]:port][,connect=host:port]

-net socket[,vlan=n][,name=name][,fd=h][,mcast=maddr:port[,localaddr=addr]]

Since we add third mode (UDP unicast) maybe it makes sense to align with currently existing modes.

Like this:
-net socket[,vlan=n][,udpconnect=sport=xxxx;dhost=a.b.c.d,dport=yyyy]

Also man page must be patched. (The VirtualBox UDP patch is much more complete, and includes docs, but is 7x times bigger size)

-Technologov


Last edited by Technologov on Thu May 12, 2011 5:43 pm, edited 1 time in total.

Top
 Profile  
 
 Post subject: Re: Patch for Qemu 0.14.0
PostPosted: Thu May 12, 2011 5:41 pm 
Offline

Joined: Tue Jul 20, 2010 5:50 pm
Posts: 93
Great work anubisg1, would be nice to have this in a state where we can submit to Qemu Dev people. Last time the patch was submitted there (2008ish) they rejected it as they didn't like the usage of word "udp" in the -net statement + they missed the comments.
Therefore I fully agree with Technologov proposal.


Top
 Profile  
 
 Post subject: Re: Patch for Qemu 0.14.0
PostPosted: Fri May 13, 2011 7:42 am 
Offline

Joined: Tue Mar 08, 2011 2:25 pm
Posts: 101
Nice work, remember not to send the e1000 patch to the Qemu mailing list, it'll be rejected anyways.

Let us know if you need help, I'd be glad to help.


Top
 Profile  
 
 Post subject: Re: Patch for Qemu 0.14.0
PostPosted: Fri May 13, 2011 9:20 am 
Offline

Joined: Fri Mar 11, 2011 7:39 pm
Posts: 603
Location: Israel
>Nice work, remember not to send the e1000 patch to the Qemu mailing list, it'll be rejected anyways.

Why is it?


Top
 Profile  
 
 Post subject: Re: Patch for Qemu 0.14.0
PostPosted: Fri May 13, 2011 10:44 am 
Offline

Joined: Wed Feb 16, 2011 5:07 pm
Posts: 114
jumbo wrote:
Great work anubisg1, would be nice to have this in a state where we can submit to Qemu Dev people. Last time the patch was submitted there (2008ish) they rejected it as they didn't like the usage of word "udp" in the -net statement + they missed the comments.
Therefore I fully agree with Technologov proposal.


actually i did almost nothing guys.. i used the patch on the first page and i fix only a couple of missing brackets.

all the regards goes to jumbo...

any way.. what's the problem with the e1000 patch ?


Top
 Profile  
 
 Post subject: Re: Patch for Qemu 0.14.0
PostPosted: Mon May 16, 2011 10:46 am 
I had several "HUNK Failed" and "malformed patch" problems while applying this patch. Probably it was because of copy&paste or sth.
I have attached it as a file after fixing all little issues.


Attachments:
File comment: Multicast patch for Qemu 0.14.1
qemu-0.14.1-multicast.patch.gz [3.01 KiB]
Downloaded 543 times
Top
  
 
 Post subject: Re: Patch for Qemu 0.14.0
PostPosted: Mon May 16, 2011 12:10 pm 
Offline

Joined: Wed Feb 16, 2011 5:07 pm
Posts: 114
is the forum that gives that problem... the patch i used can be downloaed from this link:

https://api.opensuse.org/public/source/ ... d1be0df01&


Top
 Profile  
 
 Post subject: Re: Patch for Qemu 0.14.0
PostPosted: Wed May 18, 2011 8:14 pm 
Offline

Joined: Fri Mar 11, 2011 7:39 pm
Posts: 603
Location: Israel
1. Is there any change you push those patches upstream ? (after you separate multicast from udp tunnel, and after you change syntax)

2. Please consider updating patch to support IPv6




Top
 Profile  
 
Display posts from previous:  Sort by  
Post new topic Reply to topic  [ 56 posts ]  Go to page Previous  1, 2, 3, 4, 5, 6  Next

All times are UTC


Who is online

Users browsing this forum: No registered users and 2 guests


You cannot post new topics in this forum
You cannot reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum
You cannot post attachments in this forum

Search for:
Jump to:  
Powered by phpBB® Forum Software © phpBB Group

phpBB SEO