GNS3
http://forum.gns3.net/

[Fixed] dynamips crash, compiled in cygwin with x86 arch
http://forum.gns3.net/topic6440-10.html
Page 2 of 2

Author:  grossmj [ Mon Jun 10, 2013 10:23 pm ]
Post subject:  Re: dynamips crash, compiled in cygwin with x86 arch

Also, do not hesitate to add other improvements to Dynamips ;) Actually I am gonna be straight, I am looking for someone to officially maintain it and compile releases for Linux/Windows/OSX. Since you understand the 'dark side' of Dynamips, you might the right candidate.

Well, let me know.

Cheers,

Author:  flaviojs [ Tue Jun 11, 2013 3:38 pm ]
Post subject:  Re: dynamips crash, compiled in cygwin with x86 arch

grossmj wrote:
Wow, good job! I suppose you extensively tested your patch?

It's the same as the quick-fix but with a different variable so the functionality has already been tested.
But just to make sure, I let it run for 24h with only 2 routers started.
That was enough to pass the 24h target without running out of memory, which had only been reached by the nojit arch. =)

grossmj wrote:
Also, do not hesitate to add other improvements to Dynamips ;) Actually I am gonna be straight, I am looking for someone to officially maintain it and compile releases for Linux/Windows/OSX. Since you understand the 'dark side' of Dynamips, you might the right candidate.

My plans for when I have more time are:
  • try to make it compile in MinGW/MinGW-w64 (using cmake), since cpu-intensive programs that use cygwin slow down the reaction time of my whole system;
  • have a go at the memory leaks;
  • consider adding memwatch (slows down the program, so disabled by default).

I don't mind maintaining dynamips until you find someone better, but I would only compile releases for Windows.

Author:  claydon_dan [ Tue Jun 11, 2013 6:59 pm ]
Post subject:  Re: dynamips crash, compiled in cygwin with x86 arch

@flaviojs @grossmj
flaviojs wrote:
but I would only compile releases for Windows.

Apologies if i'm speaking out of turn... but i'm sure if @flaviojs can maintain the actual dynamips coding, I could offer my support to manage the dynamips compiling for Linux, all being well. I'm currently in the process of getting debian setup with cowbuilder (to build the differant architectures) in relation to the Debian Packaging I've started.

Author:  grossmj [ Tue Jun 11, 2013 8:50 pm ]
Post subject:  Re: dynamips crash, compiled in cygwin with x86 arch

@flaviojs

Quote:
It's the same as the quick-fix but with a different variable so the functionality has already been tested.
But just to make sure, I let it run for 24h with only 2 routers started.
That was enough to pass the 24h target without running out of memory, which had only been reached by the nojit arch. =)


Excellent, I committed your patches on Dynamips-community repository.

Quote:
My plans for when I have more time are:

try to make it compile in MinGW/MinGW-w64 (using cmake), since cpu-intensive programs that use cygwin slow down the reaction time of my whole system;
have a go at the memory leaks;
consider adding memwatch (slows down the program, so disabled by default).


I would love to drop cygwin too :)

@claydon_dan @flaviojs

Quote:
I don't mind maintaining dynamips until you find someone better, but I would only compile releases for Windows.


No worries, claydon_dan you take care of the Linux compilation and I will do it for OSX.

Thanks guys!

Author:  flaviojs [ Wed Jun 12, 2013 2:15 am ]
Post subject:  Re: dynamips crash, compiled in cygwin with x86 arch

grossmj wrote:
Excellent, I committed your patches on Dynamips-community repository.

Nice, but the log message is incorrect. =~~
I didn't fix memory leaks, I only discovered them in the process.
I fixed a crash caused by the use of memory that was already free (dangling pointers).

Also, you probably didn't notice but the patch contains the log message "Avoid dangling pointers when the ppc32 cpu is recompiling a tcb and an exec page needs to be allocated, causing the tcb to be flushed."
I used "hg export" instead of "hg diff" exactly because it maintains the commit info. ;D

-----

I guess it's a go for managing dynamips-community then.

Here's my public key so that you can grant me access to the repo:
Code:
ssh-rsa AAAAB3NzaC1yc2EAAAABJQAAAIEAnYrRsiTsYmE+PMEL005lEFPk5bCNqRwi2c2kTWIkw7A7Y4ujuRuboceYxNxRIMGKNgsQDiBGlGERi0M04nRBXPlFlbKtmM9cnbyhhnsdQvTokvL6bf4OQpDc2OMSTqx1jfv1Bag1kge11flaJGE90f+DbKkGzT7aCKIqMnUj7wk= [email protected]

I'm this guy in sourceforge, add me so I can upload my compiles.

When should the RC/version change?
Is there anything else I should keep up to date?

Author:  grossmj [ Wed Jun 12, 2013 6:05 am ]
Post subject:  Re: dynamips crash, compiled in cygwin with x86 arch

Hi,

Quote:
Nice, but the log message is incorrect. =~~
I didn't fix memory leaks, I only discovered them in the process.
I fixed a crash caused by the use of memory that was already free (dangling pointers).

Also, you probably didn't notice but the patch contains the log message "Avoid dangling pointers when the ppc32 cpu is recompiling a tcb and an exec page needs to be allocated, causing the tcb to be flushed."
I used "hg export" instead of "hg diff" exactly because it maintains the commit info. ;D


Sorry, I did it in a rush and did not notice.

BTW, I moved the Dynamips repository to Github: http://github.com/GNS3/dynamips-community

Do you have a github account so I can add you to the repo?

As a side note: GNS3 will move to github as well after the 0.8.4 final version is released.

Quote:
I'm this guy in sourceforge, add me so I can upload my compiles.


I added you, please use the Dynamips directory :)

Quote:
When should the RC/version change?
Is there anything else I should keep up to date?


I think we should stop creating RC version for this version (0.2.8) and release the final soon. Then version changes should happen every GNS3 release if the code has changed.

Also I was thinking about merging the unstable and stable branches.

Thanks for your contribution! This is very helpful.

Author:  Jason [ Wed Jun 12, 2013 6:21 am ]
Post subject:  Re: dynamips crash, compiled in cygwin with x86 arch

@flaviojs

All I can say is "wow" and "thank you!" Nice job on tracking these issues down. I truly appreciate the contribution of talented folks like yourself.


Cheers,
Jason

Author:  flaviojs [ Wed Jun 12, 2013 9:13 pm ]
Post subject:  Re: dynamips crash, compiled in cygwin with x86 arch

@grossmj
grossmj wrote:
BTW, I moved the Dynamips repository to Github: http://github.com/GNS3/dynamips-community

Do you have a github account so I can add you to the repo?

As a side note: GNS3 will move to github as well after the 0.8.4 final version is released.

I'm this guy in github.

github is awesome, I recommend it. thumbs up ^^

Btw, don't forget to update this page.

grossmj wrote:
I think we should stop creating RC version for this version (0.2.8) and release the final soon. Then version changes should happen every GNS3 release if the code has changed.

Also I was thinking about merging the unstable and stable branches.

Thanks for your contribution! This is very helpful.

Hmm, I should at least have a go at the memory leaks before the version changes. The rest can be done after.

Regarding merging stable/unstable, testing unstable comes first.

-----

@claydon_dan
claydon_dan wrote:
I could offer my support to manage the dynamips compiling for Linux

Thanks, feel free to submit changes to the build system (Makefiles and whatever else you think is appropriate). =)

-----

@Jason

Thanks =)

Author:  grossmj [ Thu Jun 13, 2013 2:24 am ]
Post subject:  Re: dynamips crash, compiled in cygwin with x86 arch

You are good to go on Github :)

Cheers,

Page 2 of 2 All times are UTC
Powered by phpBB® Forum Software © phpBB Group
http://www.phpbb.com/